----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69972/#review212902 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp Line 92 (original), 92 (patched) <https://reviews.apache.org/r/69972/#comment298782> `orphaned` sounds more straightforward to me than `recoverable`. Especially, when you are not familiar with our containerization subsystem. - Andrei Budnik On Feb. 18, 2019, 2:31 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69972/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2019, 2:31 p.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9507 > https://issues.apache.org/jira/browse/MESOS-9507 > > > Repository: mesos > > > Description > ------- > > There are two cases we need to handle: > 1. The checkpointed docker volumes file does not exist. > 2. The checkpointed docker volumes file is empty. > For both of the two cases, in the recovery of `docker/volume` isolator, > we should remove the orphan container's checkpoint directory and then > skip the container. But for recoverable containers, we return an error > since the above two cases should not happen for them. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > 2fd0493bc3e1749c12b81b9f2d281b86cb2c410f > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > a72fc84da6fb0f24d363dd4c635500510da675d8 > > > Diff: https://reviews.apache.org/r/69972/diff/3/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
