-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69972/
-----------------------------------------------------------
(Updated Feb. 20, 2019, 2:17 p.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Changes
-------
Reused `cleanup` to remove container directory rather than doing it directly in
`_recover`.
Summary (updated)
-----------------
Handled containers which has no checkpointed volumes during recovery.
Bugs: MESOS-9507
https://issues.apache.org/jira/browse/MESOS-9507
Repository: mesos
Description (updated)
-------
There are two cases we need to handle:
1. The container's checkpointed docker volumes file does not exist.
2. The container's checkpointed docker volumes file is empty.
For both of the two cases, in the recovery of `docker/volume` isolator,
we should construct an info object with empty docker volumes for the
container and rely on containerizer or `docker/volume` isolator's
`recover` method to cleanup the container.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp
a72fc84da6fb0f24d363dd4c635500510da675d8
Diff: https://reviews.apache.org/r/69972/diff/4/
Changes: https://reviews.apache.org/r/69972/diff/3-4/
Testing
-------
Thanks,
Qian Zhang
