> On Feb. 18, 2019, 11:48 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > > Line 92 (original), 92 (patched) > > <https://reviews.apache.org/r/69972/diff/3/?file=2125760#file2125760line92> > > > > `orphaned` sounds more straightforward to me than `recoverable`. > > Especially, when you are not familiar with our containerization subsystem.
Had a discussion with Gilbert, we agree we'd better not to differentiate recoverable containers and orphaned containers in this patch. What you pointed out (recoverable containers must not have empty checkpoint file) actualy exists in other isolators as well (e.g., CNI), we may consider to improve them in a separate patch in future. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69972/#review212902 ----------------------------------------------------------- On Feb. 20, 2019, 2:17 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69972/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2019, 2:17 p.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9507 > https://issues.apache.org/jira/browse/MESOS-9507 > > > Repository: mesos > > > Description > ------- > > There are two cases we need to handle: > 1. The container's checkpointed docker volumes file does not exist. > 2. The container's checkpointed docker volumes file is empty. > For both of the two cases, in the recovery of `docker/volume` isolator, > we should construct an info object with empty docker volumes for the > container and rely on containerizer or `docker/volume` isolator's > `recover` method to cleanup the container. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > a72fc84da6fb0f24d363dd4c635500510da675d8 > > > Diff: https://reviews.apache.org/r/69972/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
