----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75062/#review226585 -----------------------------------------------------------
support/jenkins/reviewbot.sh Line 50 (original), 50 (patched) <https://reviews.apache.org/r/75062/#comment314861> can you add a comment here about why we disable java? support/mesos-build/entrypoint.sh Lines 70 (patched) <https://reviews.apache.org/r/75062/#comment314862> hm.. is this supposed to be needed for distcheck to pass? shouldn't distcheck be performing what's missing that running `make` first solves? - Benjamin Mahler On June 24, 2024, 4:09 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75062/ > ----------------------------------------------------------- > > (Updated June 24, 2024, 4:09 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Adds an extra build before running distcheck so that the > csi/v0/csi.grpc.pb.cc is available for distdir. Additionally, we disable java > here as it causes errors with performing distcheck. > > TODO: we will have to remake the docker images to get the updated > entrypoint.sh file, and upload them to dockerhub. > > > Diffs > ----- > > support/jenkins/reviewbot.sh 03ebcd6007d6da9bfb5ef0d2b3f84b1f83219127 > support/mesos-build/entrypoint.sh 38c6f564413ba3916caf5c024be500b8113618e6 > > > Diff: https://reviews.apache.org/r/75062/diff/1/ > > > Testing > ------- > > Ran entrypoint.sh on mac in container using a new amd64 image. Distcheck was > able to complete successfully. > > > Thanks, > > Jason Zhou > >
