-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75062/#review226600
-----------------------------------------------------------




support/mesos-build/entrypoint.sh
Lines 72 (patched)
<https://reviews.apache.org/r/75062/#comment314873>

    Changed to use make all-local in /3rdparty as it takes less time and still 
allows us to get the .proto files for csi


- Jason Zhou


On June 25, 2024, 7:44 p.m., Jason Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75062/
> -----------------------------------------------------------
> 
> (Updated June 25, 2024, 7:44 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds an extra build before running distcheck so that the 
> csi/v0/csi.grpc.pb.cc is available for distdir. Additionally, we disable java 
> here as it causes errors with performing distcheck.
> 
> TODO: we will have to remake the docker images to get the updated 
> entrypoint.sh file, and upload them to dockerhub.
> 
> 
> Diffs
> -----
> 
>   support/jenkins/reviewbot.sh 03ebcd6007d6da9bfb5ef0d2b3f84b1f83219127 
>   support/mesos-build/entrypoint.sh 38c6f564413ba3916caf5c024be500b8113618e6 
> 
> 
> Diff: https://reviews.apache.org/r/75062/diff/2/
> 
> 
> Testing
> -------
> 
> Ran entrypoint.sh on mac in container using a new amd64 image. Distcheck was 
> able to complete successfully.
> 
> 
> Thanks,
> 
> Jason Zhou
> 
>

Reply via email to