> On June 24, 2024, 6:31 p.m., Benjamin Mahler wrote: > > support/mesos-build/entrypoint.sh > > Lines 70 (patched) > > <https://reviews.apache.org/r/75062/diff/1/?file=2289252#file2289252line70> > > > > hm.. is this supposed to be needed for distcheck to pass? shouldn't > > distcheck be performing what's missing that running `make` first solves? > > Jason Zhou wrote: > Ideally we wouldn't need to do this, but the protobuf file doest seem to > get generated when using autotools distcheck target in ubuntu20.04, And we > get this error: > make[3]: Entering directory '/tmp/SRC/build/src' > make[3]: No rule to make target '../include/csi/v0/csi.grpc.pb.cc', > needed by 'distdir'. Stop. > I double checked by going into /tmp/SRC/build/include/csi/v0/ after > running distcheck, and there is indeed nothing in that folder at all. > By performing a make beforehand, this error goes away as the protobuf > file is generated beforehand and is available for the distdir target.
Is there a way that we can just fix distcheck to work without requiring a make beforehand? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75062/#review226585 ----------------------------------------------------------- On June 25, 2024, 7:44 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75062/ > ----------------------------------------------------------- > > (Updated June 25, 2024, 7:44 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Adds an extra build before running distcheck so that the > csi/v0/csi.grpc.pb.cc is available for distdir. Additionally, we disable java > here as it causes errors with performing distcheck. > > TODO: we will have to remake the docker images to get the updated > entrypoint.sh file, and upload them to dockerhub. > > > Diffs > ----- > > support/jenkins/reviewbot.sh 03ebcd6007d6da9bfb5ef0d2b3f84b1f83219127 > support/mesos-build/entrypoint.sh 38c6f564413ba3916caf5c024be500b8113618e6 > > > Diff: https://reviews.apache.org/r/75062/diff/2/ > > > Testing > ------- > > Ran entrypoint.sh on mac in container using a new amd64 image. Distcheck was > able to complete successfully. > > > Thanks, > > Jason Zhou > >
