----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75062/#review226618 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On June 26, 2024, 10:34 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75062/ > ----------------------------------------------------------- > > (Updated June 26, 2024, 10:34 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Fixes the makefiles for ubuntu20.04 so that the distcheck works properly with > its protobuf dependencies generated as part of make distcheck. > > The reason that a change was needed in the makefile is because the upgrade > from ubuntu 16.04 to 20.04 also caused the automake version to be updated > when dependencies were being installed during docker build. > > The change in the automake version created slight changes in the generated > makefile. Speficically, the distcheck on the new automake-generated makefile > now depended on `BUILT_SOURCES` which causes an error as the CSI protobuf > files are not ready when distcheck is called. So we add the csi build stamps > to `BUILT_SOURCES` to ensure that the protobuf files will be ready when > distcheck's dependencies are made. > > The additional chmod change for java is because for some reason when > distcheck attempts to build the mesos-1.12.0.jar from its created > distribution, some folders are missing write permissions, causing the build > to terminate. > > > Diffs > ----- > > 3rdparty/Makefile.am 55f49ee59e99ab112c3f4ce9ec2e7d0a071cdf79 > src/Makefile.am b6acfb5ea214b0196a879e548e7a1ad39a3e8971 > > > Diff: https://reviews.apache.org/r/75062/diff/3/ > > > Testing > ------- > > Ran entrypoint.sh on mac in container using a new amd64 image. Distcheck was > able to complete successfully. > > > Thanks, > > Jason Zhou > >
