Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3683#issuecomment-74180612
I think we can finish and merge this. The current logic of the script is
"if anything is running at the PID given in the file, fail". Your change is "if
the Spark daemon we expect is running at the PID given in the file, fail" --
meaning in the case where somehow the PID files wasn't cleaned up and another
process has that PID, we continue.
That's good. I had suggested cleaning up the PID file when it's known it's
not the Spark daemon. But I see that in the start case, the PID file is
overwritten anyway. In the stop case, it's not cleared, but, maybe that's not
so important.
So, I think that is actually already addressed. Could I get @nchammas to
render an opinion on the bash syntax -- are we not doing back ticks? Otherwise
I think it's a good one to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
