Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3683#discussion_r24640723
--- Diff: sbin/spark-daemon.sh ---
@@ -164,9 +165,10 @@ case $option in
(stop)
if [ -f $pid ]; then
- if kill -0 `cat $pid` > /dev/null 2>&1; then
+ TARGET_ID=`cat $pid`
+ if [[ `ps -p $TARGET_ID -o args=` =~ $command ]]; then
echo stopping $command
- kill `cat $pid`
+ kill $TARGET_ID
else
echo no $command to stop
--- End diff --
I know this was not part of your changes, but we should also quote this
whole string here, too.
```
echo "no $command to stop"
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
