Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3683#discussion_r24640629
--- Diff: sbin/spark-daemon.sh ---
@@ -129,8 +129,9 @@ case $option in
mkdir -p "$SPARK_PID_DIR"
if [ -f $pid ]; then
- if kill -0 `cat $pid` > /dev/null 2>&1; then
- echo $command running as process `cat $pid`. Stop it first.
+ TARGET_ID=`cat $pid`
--- End diff --
Bash style: Use `$(...)` instead of backticks, which are discouraged.
Also, quote the output of the subshell, as well as the variable argument to
`cat`:
```
TARGET_ID="$(cat "$pid")"
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
