Github user MattWhelan commented on a diff in the pull request:
https://github.com/apache/spark/pull/4690#discussion_r25010357
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -148,7 +148,13 @@ private[spark] class DiskBlockManager(blockManager:
BlockManager, conf: SparkCon
/** Cleanup local dirs and stop shuffle sender. */
private[spark] def stop() {
// Remove the shutdown hook. It causes memory leaks if we leave it
around.
- Runtime.getRuntime.removeShutdownHook(shutdownHook)
+ if(shutdownHook != null) {
--- End diff --
I don't think it can be. Unless you're calling `stop` before the
constructor has finished, which doesn't seem possible.
The docs for `removeShutdownHook` imply that you can pass it any thread,
and it'll just return false if that thread isn't currently registered, so even
double-calls are unlikely to cause problems there. There's just the
IllegalStateException, which could happen if someone else's shutdown hook is
calling stop. That's definitely worth protecting against.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
