MaxGekk commented on a change in pull request #27456:
[SPARK-25040][SQL][FOLLOWUP] Add legacy config for allowing empty strings for
certain types in json parser
URL: https://github.com/apache/spark/pull/27456#discussion_r374879103
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
##########
@@ -307,6 +308,8 @@ class JacksonParser(
}
}
+ private lazy val allowEmptyString =
SQLConf.get.getConf(SQLConf.LEGACY_ALLOW_EMPTY_STRING_IN_JSON)
Review comment:
We could avoid the overhead of checking **lazy** val. Do you see any problem
if it will be just val?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
