dongjoon-hyun commented on a change in pull request #27456:
[SPARK-25040][SQL][FOLLOWUP] Add legacy config for allowing empty strings for
certain types in json parser
URL: https://github.com/apache/spark/pull/27456#discussion_r374917275
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
##########
@@ -317,8 +320,18 @@ class JacksonParser(
// SPARK-25040: Disallow empty strings for data types except for string
and binary types.
case VALUE_STRING if parser.getTextLength < 1 =>
Review comment:
Instead of the below 14 line changes, shall we add this 7 lines before this
line?
```scala
case VALUE_STRING if parser.getTextLength < 1 && allowEmptyString =>
dataType match {
case FloatType | DoubleType | TimestampType | DateType =>
throw new RuntimeException(
s"Failed to parse an empty string for data type
${dataType.catalogString}")
case _ => null
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
