dongjoon-hyun commented on a change in pull request #27456:
[SPARK-25040][SQL][FOLLOWUP] Add legacy config for allowing empty strings for
certain types in json parser
URL: https://github.com/apache/spark/pull/27456#discussion_r374918949
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
##########
@@ -2469,6 +2475,28 @@ abstract class JsonSuite extends QueryTest with
SharedSparkSession with TestJson
emptyString(StringType, "")
emptyString(BinaryType, "".getBytes(StandardCharsets.UTF_8))
+
+ // Legacy mode prior to Spark 3.0.0
+ withSQLConf(SQLConf.LEGACY_ALLOW_EMPTY_STRING_IN_JSON.key -> "true") {
+ emptyStringAsNull(BooleanType)
+ emptyStringAsNull(ByteType)
+ emptyStringAsNull(ShortType)
+ emptyStringAsNull(IntegerType)
+ emptyStringAsNull(LongType)
+
+ failedOnEmptyString(FloatType)
+ failedOnEmptyString(DoubleType)
+ failedOnEmptyString(TimestampType)
+ failedOnEmptyString(DateType)
+
+ emptyStringAsNull(DecimalType.SYSTEM_DEFAULT)
+ emptyStringAsNull(ArrayType(IntegerType))
+ emptyStringAsNull(MapType(StringType, IntegerType, true))
+ emptyStringAsNull(StructType(StructField("f1", IntegerType, true) ::
Nil))
+
+ emptyString(StringType, "")
+ emptyString(BinaryType, "".getBytes(StandardCharsets.UTF_8))
+ }
Review comment:
That will be easier to remove this later. Otherwise, we may forget to remove
`emptyStringAsNull`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
