MaxGekk commented on issue #27491: [SPARK-30754][SQL] Reuse results of floorDiv in calculations of floorMod in DateTimeUtils URL: https://github.com/apache/spark/pull/27491#issuecomment-583878390 @kiszk The ops are not regular arithmetic `/` and `%`, they are lib calls. So, they present in byte code: ``` public microsToInstant(J)Ljava/time/Instant; // parameter final us L0 LINENUMBER 339 L0 LLOAD 1 LDC 1000000 INVOKESTATIC java/lang/Math.floorDiv (JJ)J L1 LSTORE 3 L2 LINENUMBER 340 L2 LLOAD 1 LDC 1000000 INVOKESTATIC java/lang/Math.floorMod (JJ)J ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
