maropu edited a comment on issue #27491: [SPARK-30754][SQL] Reuse results of floorDiv in calculations of floorMod in DateTimeUtils URL: https://github.com/apache/spark/pull/27491#issuecomment-583908886 The fix looks fine to me. If you have performance numbers, could you put them in the PR decription?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
