maropu commented on a change in pull request #27491: [SPARK-30754][SQL] Reuse
results of floorDiv in calculations of floorMod in DateTimeUtils
URL: https://github.com/apache/spark/pull/27491#discussion_r376827899
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -337,7 +337,7 @@ object DateTimeUtils {
def microsToInstant(us: Long): Instant = {
val secs = Math.floorDiv(us, MICROS_PER_SECOND)
- val mos = Math.floorMod(us, MICROS_PER_SECOND)
+ val mos = us - secs * MICROS_PER_SECOND
Review comment:
For better readability, could you leave some comments about the calculation
reuse here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
