tgravescs commented on a change in pull request #27693: [SPARK-30947][CORE]
Don't log accelerate resources when it's empty
URL: https://github.com/apache/spark/pull/27693#discussion_r383929970
##########
File path: core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala
##########
@@ -194,7 +194,9 @@ class ResourceProfile(
throw new SparkException("No executor resource configs were not
specified for the " +
s"following task configs: ${taskResourcesToCheck.keys.mkString(",")}")
}
- logInfo(s"Limiting resource is $limitingResource at $taskLimit tasks per
executor")
+ if (limitingResource.nonEmpty) {
+ logInfo(s"Limiting resource is $limitingResource at $taskLimit tasks per
executor")
Review comment:
yes I meant to leave it as it tells you something. Yes the way it prints
could definitely be more readable in the empty case. The lack of it being
there can tell you the same thing but to me it's much easier to search the logs
for something that is always there.
Depends on who your end user is. If you are support person helping end user
then I see it as possibly useful which is why I made it an info log. I figure
with this being new and perhaps people don't configuring these properly users
can use this to see why they might not be getting as many tasks per executor as
they want. So from that point they would care about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
