Ngone51 commented on a change in pull request #27693: [SPARK-30947][CORE] Don't
log accelerate resources when it's empty
URL: https://github.com/apache/spark/pull/27693#discussion_r383923456
##########
File path: core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala
##########
@@ -194,7 +194,9 @@ class ResourceProfile(
throw new SparkException("No executor resource configs were not
specified for the " +
s"following task configs: ${taskResourcesToCheck.keys.mkString(",")}")
}
- logInfo(s"Limiting resource is $limitingResource at $taskLimit tasks per
executor")
+ if (limitingResource.nonEmpty) {
+ logInfo(s"Limiting resource is $limitingResource at $taskLimit tasks per
executor")
Review comment:
I'm not going to remove it but only avoid it when we don't check executor
cores. Because when `shouldCheckExecCores` is `false`, `limitingResource` is
empty and `taskLimit` is -1.
Do you really intentionally to log this?
BTW, I don't think end-user would learn anything related to source code from
the log and they may even don't care about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
