tgravescs commented on a change in pull request #27693: [SPARK-30947][CORE]
Don't log accelerate resources when it's empty
URL: https://github.com/apache/spark/pull/27693#discussion_r383915669
##########
File path: core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala
##########
@@ -194,7 +194,9 @@ class ResourceProfile(
throw new SparkException("No executor resource configs were not
specified for the " +
s"following task configs: ${taskResourcesToCheck.keys.mkString(",")}")
}
- logInfo(s"Limiting resource is $limitingResource at $taskLimit tasks per
executor")
+ if (limitingResource.nonEmpty) {
+ logInfo(s"Limiting resource is $limitingResource at $taskLimit tasks per
executor")
Review comment:
Again I'm ok with removing it but don't see the problem with it as is
either, though could be easier to read when empty, it tells you something about
the code and what it did which is the point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
