HeartSaVioR commented on a change in pull request #27831: [SPARK-31069][CORE]
high cpu caused by chunksBeingTransferred in external shuffle service
URL: https://github.com/apache/spark/pull/27831#discussion_r389370836
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
##########
@@ -192,11 +196,7 @@ public void streamSent(String streamId) {
@Override
public long chunksBeingTransferred() {
- long sum = 0L;
- for (StreamState streamState: streams.values()) {
- sum += streamState.chunksBeingTransferred.get();
- }
Review comment:
Have you measured how long the thread is being stuck on calculation here?
And how frequently this method is called?
It would be ideal to craft a simple benchmark code and experiment with some
variations: num of chunks, contentions (no contention, one thread calling
chunkSent, N threads doing the same).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
