HeartSaVioR commented on a change in pull request #27831: [SPARK-31069][CORE]
high cpu caused by chunksBeingTransferred in external shuffle service
URL: https://github.com/apache/spark/pull/27831#discussion_r389453650
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
##########
@@ -192,11 +196,7 @@ public void streamSent(String streamId) {
@Override
public long chunksBeingTransferred() {
- long sum = 0L;
- for (StreamState streamState: streams.values()) {
- sum += streamState.chunksBeingTransferred.get();
- }
Review comment:
Looks like the method is not called at only once, so the optimization seems
to make sense. Still would be better to have some numbers to back up
rationalization of the patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
