Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/4845#issuecomment-76863248
  
    Hi @twinkle-sachdeva,
    
    The code in HistoryPage.scala feels a little confusing, and I think it 
could be written more cleanly by choosing more appropriate data structures. 
Since it needs to create some new data structures based on the app listing, we 
should avoid always translating the whole list of apps, instead only 
translating the necessary info to fill the current page, to keep memory usage 
in check.
    
    I took a quick look at `UIUtils.listingTable` and it seems like it's easy 
to generate multiple rows for each `generateDataRow` callback, so using the 
data structure I suggested should be relatively easy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to