Github user twinkle-sachdeva commented on a diff in the pull request:
https://github.com/apache/spark/pull/4845#discussion_r25688020
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
@@ -34,18 +37,31 @@ private[spark] class HistoryPage(parent: HistoryServer)
extends WebUIPage("") {
val requestedIncomplete =
Option(request.getParameter("showIncomplete")).getOrElse("false").toBoolean
- val allApps = parent.getApplicationList().filter(_.completed !=
requestedIncomplete)
- val actualFirst = if (requestedFirst < allApps.size) requestedFirst
else 0
- val apps = allApps.slice(actualFirst, Math.min(actualFirst + pageSize,
allApps.size))
-
+ val allCompletedAppsNAttempts =
+ parent.getApplicationList().filter(_.completed !=
requestedIncomplete)
+ val (hasAttemptInfo, appToAttemptMap) =
getApplicationLevelList(allCompletedAppsNAttempts)
--- End diff --
Hi,
If at a particular time, there are few event logs, which have attempt info,
and there are few, which do no have. Then we display the same number of columns
irrespective of the event log having attempt info or not.
To do above, we need just one flag of hasAttemptInfo for all the
applications we have, and it is not per application. If we do that map logic,
then we will need to iterate again on that map, after creating the same.
Regarding that memory exploding, if we first slice, and at a time ( in the
case, when history server is restarting with some event logs already there ),
then we might see one page's UI without attempt info, and another page with
attempt UI. Is it fine?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
