HyukjinKwon commented on a change in pull request #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392837101
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
Review comment:
Actually I was thinking about this one. Seems few expressions override
`nodeName` directly but I am not sure if that's correct. Node name seems to be
usually the class name; not lower-cased names. Fixing `prettyName` looks good
enough to address the issue in output column names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
