HyukjinKwon commented on a change in pull request #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392869652
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
Review comment:
Yes, I agree with that point. But here why don't we just don't touch
`nodeName` and revisit next time?
If we override `prettyName`, most of cases such as `simpleString` and `sql`
and will be addressed.
My impression about `prettyName` via `sql` call is user-facing string (as
it's used in `sql` as of
https://github.com/apache/spark/commit/d9efe63ecdc60a9955f1924de0e8a00bcb6a559d).
and `nodeName` seems more like related to internal and debugging. If we have
to debug, we should take a look for class names rather then what alias was used
by the user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
