cloud-fan commented on a change in pull request #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392854623
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
Review comment:
damn I miss read it. Then it won't work for physical plans as we remove the
`Exec` postfix. And I would say it's much more reliable to use
`getClass.getSimpleName` in this case...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
