Github user CodingCat commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5004#discussion_r26443557
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -93,7 +93,7 @@ private[history] class FsHistoryProvider(conf: SparkConf) 
extends ApplicationHis
        */
       private def getRunner(operateFun: () => Unit): Runnable = {
         new Runnable() {
    -      override def run() = Utils.logUncaughtExceptions {
    +      override def run() = Utils.tryOrExit {
    --- End diff --
    
    FsHistoryProvider is the module used by history server process to render 
the application logs....
    
    this getRunner is called for periodically check updated logs and clean 
logs...
    
    the point here is if anything uncaught is thrown, like OOM, HistoryServer 
process should be restarted, since it has been unfunctional...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to