Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/5004#discussion_r26633429
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1156,6 +1158,28 @@ private[spark] object Utils extends Logging {
}
/**
+ * Execute a block of code that evaluates to Unit, stop SparkContext is
there is any uncaught
+ * exception
+ *
+ * NOTE: This method is to be called by the driver-side components to
avoid stopping the
+ * user-started JVM process completely; in contrast, tryOrExit is to be
called in the
+ * spark-started JVM process .
+ */
+ def tryOrStopSparkContext(sc: SparkContext)(block: => Unit) {
+ try {
+ block
+ } catch {
+ case e: ControlThrowable => throw e
+ case t: Throwable =>
+ if (sc != null) {
+ logError(s"uncaught error in thread
${Thread.currentThread().getName}, stopping " +
+ "SparkContext", t)
+ sc.stop()
+ }
--- End diff --
How about throwing `t` again here? So that the user can use
`UncaughtExceptionHandler` to monitor the uncaught exception. If not, the user
won't be aware that `sc` is shutdown. until calling `runJob` next time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
