srowen commented on a change in pull request #28532:
URL: https://github.com/apache/spark/pull/28532#discussion_r425457945
##########
File path: dev/test-dependencies.sh
##########
@@ -47,7 +47,7 @@ OLD_VERSION=$($MVN -q \
-Dexec.executable="echo" \
-Dexec.args='${project.version}' \
--non-recursive \
- org.codehaus.mojo:exec-maven-plugin:1.6.0:exec)
+ org.codehaus.mojo:exec-maven-plugin:1.6.0:exec | grep -e
'[0-9]\.[0-9]\.[0-9]')
Review comment:
This would still match `3.1.0-SNAPSHOT` wouldn't it - was the idea not
to match it?
You could exclude "SNAPSHOT" matches but that might be just a band-aid.
You might need `[0-9]+` in each case to account for double-digit versions.
`\d` might work with `-E` but not worth it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
