srowen commented on a change in pull request #28532:
URL: https://github.com/apache/spark/pull/28532#discussion_r425498195
##########
File path: dev/test-dependencies.sh
##########
@@ -47,7 +47,7 @@ OLD_VERSION=$($MVN -q \
-Dexec.executable="echo" \
-Dexec.args='${project.version}' \
--non-recursive \
- org.codehaus.mojo:exec-maven-plugin:1.6.0:exec)
+ org.codehaus.mojo:exec-maven-plugin:1.6.0:exec | grep -e
'[0-9]\.[0-9]\.[0-9]')
Review comment:
Maybe I'm still missing it, but this will still match the whole line -
do you need `-o` on the grep to just return the matching part? I'd still
account for double-digit versions here to avoid errors one day when there is a
.10 or whatever.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
