srowen commented on a change in pull request #28532:
URL: https://github.com/apache/spark/pull/28532#discussion_r425517358



##########
File path: dev/test-dependencies.sh
##########
@@ -47,7 +47,7 @@ OLD_VERSION=$($MVN -q \
     -Dexec.executable="echo" \
     -Dexec.args='${project.version}' \
     --non-recursive \
-    org.codehaus.mojo:exec-maven-plugin:1.6.0:exec)
+    org.codehaus.mojo:exec-maven-plugin:1.6.0:exec | grep -e 
'[0-9]\.[0-9]\.[0-9]')

Review comment:
       It works but you need `-E` as that is 'extended' regex syntax, like many 
things. I think `-E` is standard across GNU / BSD grep.
   
   OK if you tell me this works, then I'm missing something, but it seems like 
this grep does not exclude the line I think you are trying to exclude, unless 
you want to print only the matching version from that line, and that's `-o` I 
understand it's picking up "Falling" so I am assuming something needs to ignore 
this line or only extract the version. `grep -v Falling` would just ignore that 
line




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to