maropu commented on a change in pull request #28683:
URL: https://github.com/apache/spark/pull/28683#discussion_r432929981
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
##########
@@ -144,7 +144,9 @@ object ResolveHints {
}
def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperatorsUp {
- case h: UnresolvedHint if
STRATEGY_HINT_NAMES.contains(h.name.toUpperCase(Locale.ROOT)) =>
+ case h: UnresolvedHint
+ if (conf.optimizerHintsEnabled &&
+ STRATEGY_HINT_NAMES.contains(h.name.toUpperCase(Locale.ROOT))) =>
Review comment:
nit format;
```
case h: UnresolvedHint if conf.optimizerHintsEnabled &&
STRATEGY_HINT_NAMES.contains(h.name.toUpperCase(Locale.ROOT)) =>
if (h.parameters.isEmpty) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
