dilipbiswal commented on a change in pull request #28683:
URL: https://github.com/apache/spark/pull/28683#discussion_r432930779
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveHintsSuite.scala
##########
@@ -294,4 +294,50 @@ class ResolveHintsSuite extends AnalysisTest {
caseSensitive = true)
}
}
+
+ test("disable hint resolution when spark.sql.optimizer.hints.enabled =
false") {
+ checkAnalysis(
+ UnresolvedHint("COALESCE", Seq(Literal(10)), table("TaBlE")),
+ testRelation,
+ caseSensitive = true,
+ enableHints = false
Review comment:
@maropu Should i move this test to SQLQuerySuite ? Actually i tried
initially to do withSQLConf, but realized that this suite creates an Analyzer
by constructing a SQLConf inside AnalysisTest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
