maropu commented on a change in pull request #28683:
URL: https://github.com/apache/spark/pull/28683#discussion_r432930260
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveHintsSuite.scala
##########
@@ -294,4 +294,50 @@ class ResolveHintsSuite extends AnalysisTest {
caseSensitive = true)
}
}
+
+ test("disable hint resolution when spark.sql.optimizer.hints.enabled =
false") {
+ checkAnalysis(
+ UnresolvedHint("COALESCE", Seq(Literal(10)), table("TaBlE")),
+ testRelation,
+ caseSensitive = true,
+ enableHints = false
Review comment:
Could you use `withSQLConf` instead for the tests? I think `enableHints`
is only used for this test suite, so we don't need to add the option in
`AnalysisTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
