Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4135#discussion_r26726595
--- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala ---
@@ -82,9 +97,27 @@ private[spark] class TaskContextImpl(
}
}
- /** Marks the task for interruption, i.e. cancellation. */
+ /**
+ * Marks the task as interruption, i.e. cancellation. We add this
--- End diff --
I'd reword this comment slightly to say something like "Marks the task for
interruption (i.e. cancellation) and calls any task interruption callbacks
registered for this task."
We already document the sample use-case on the public
addTaskInterruptionListener callback, so I don't think we need to do it here as
well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
