Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4135#discussion_r26726883
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
 ---
    @@ -295,6 +296,14 @@ class ReceiverTracker(ssc: StreamingContext, 
skipReceiverLaunch: Boolean = false
             val receiver = iterator.next()
             val supervisor = new ReceiverSupervisorImpl(
               receiver, SparkEnv.get, serializableHadoopConf.value, 
checkpointDirOption)
    +
    +        // Due to SPARK-5205, `Receiver` stage can not be stopped 
properly, we need to add a
    --- End diff --
    
    It's fine to be a bit more explicit / verbose about what's going on here, 
so I'd maybe update this comment to say something like this:
    
    > To ensure that receivers are stopped properly when their tasks / stages 
are killed, register a callback to stop the receiver when its task is 
interrupted.  See SPARK-5205 for more details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to