Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4135#issuecomment-83291328
I left a pass of comments, mostly about naming / documentation things. The
overall approach looks good, but I'm not sure if this is the right / best unit
test for this logic because the test harness seems to duplicate most of the
logic being tested. I'll let @tdas chime in regarding tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
