Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5115#issuecomment-84376478
@nyaapa rather than link to your commit, you should open a PR in general.
But since we already have a PR here, maybe we can collaborate here. You have
more changes than what I think this change requires, like using hostnames
instead of IP in some places, and I don't know the consequence of that.
@achanda I understand this already, but, if you look at usages of the value
you change, it is not clear that they want a URI-formatted string. It is after
all supposed to be a host name and that what is being returned.
It may be that one instance of the caller wants to make a URI but then
that's what changes, right? this value could return `InetAddress` instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
