Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5115#discussion_r26902267
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -792,6 +793,11 @@ private[spark] object Utils extends Logging {
lazy val localIpAddress: String = findLocalIpAddress()
lazy val localIpAddressHostname: String =
getAddressHostName(localIpAddress)
+ def localIpURI(): String = {
--- End diff --
I have a small concern that this isn't actually returning a URI, but just
an IP address in URI-friendly form. Shouldn't callers just use
`InetAddresses.toUriString()` if needed? there's already a utility method for
this, and doesn't need a new one in `Utils`. Yes, this also ignores the logic
behind `localIpAddress` and `localIpAddressHostname`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
