Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5115#discussion_r26896933
--- Diff:
core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala ---
@@ -17,10 +17,13 @@
package org.apache.spark.deploy
+import java.net.InetAddress
+
import scala.collection.mutable.ArrayBuffer
import akka.actor.ActorSystem
+import com.google.common.net.InetAddresses
--- End diff --
Tiny nit: this import can be grouped with the `akka` one above instead of
Spark imports.
I like this change. How about the use of `Utils.localIpAddress` in
`HttpServer`? It might need a similar treatment, I don't know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
