HyukjinKwon commented on pull request #26440: URL: https://github.com/apache/spark/pull/26440#issuecomment-646376704
For this PR specifically, I think it should have been explicitly approved as it affects all other components and it's pretty big. I think here is when we needed to call more reviews, and explicit approvals. For https://github.com/apache/spark/pull/28370 specifically, the review feedback was not fully addressed, but just merged. Maybe we should better avoid merging in this way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
