HyukjinKwon commented on pull request #26440: URL: https://github.com/apache/spark/pull/26440#issuecomment-646385210
I haven't looked into the codes closely yet - I will try to read and follow more closely. I just noticed the discussions made in these PRs which are virtually from you. My point is that: - Here looks, to me, when we needed to call more review and explicit approvals given that this affects all other components in Spark. - Seems the review comments are not fully addressed, but being merged. I see that PR #28370 was merged right away after leaving https://github.com/apache/spark/pull/28370#issuecomment-630363255. - It looks we needed to have a SPIP. It looks to me that we're rushing on these PRs where actually we should be the most conservative. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
