MaxGekk commented on a change in pull request #27366:
URL: https://github.com/apache/spark/pull/27366#discussion_r443192265
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmark.scala
##########
@@ -508,6 +548,7 @@ object JsonBenchmark extends SqlBasedBenchmark {
jsonInDS(50 * 1000 * 1000, numIters)
jsonInFile(50 * 1000 * 1000, numIters)
datetimeBenchmark(rowsNum = 10 * 1000 * 1000, numIters)
+ filtersPushdownBenchmark(rowsNum = 100 * 1000, numIters)
Review comment:
This PR doesn't support pushdown filters with nested attributes. The
benchmarks will be useless. I would prefer to don't add such benchmark in the
PR because re-running the benchmark on JDK 8 & 11 takes much time (> 1 hour).
And I am not sure what the benchmark will show to us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
