MaxGekk commented on a change in pull request #27366:
URL: https://github.com/apache/spark/pull/27366#discussion_r443196767
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmark.scala
##########
@@ -508,6 +548,7 @@ object JsonBenchmark extends SqlBasedBenchmark {
jsonInDS(50 * 1000 * 1000, numIters)
jsonInFile(50 * 1000 * 1000, numIters)
datetimeBenchmark(rowsNum = 10 * 1000 * 1000, numIters)
+ filtersPushdownBenchmark(rowsNum = 100 * 1000, numIters)
Review comment:
1. I opened this PR on 27 January 2020 before filters w/ nested attrs
are supported.
2. End users can get benefits from this PR already
3. Nested filters attr will make this PR more complex, and hard to review.
4. The feature can be implemented separately on top of the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
