MaxGekk commented on a change in pull request #27366:
URL: https://github.com/apache/spark/pull/27366#discussion_r443237059
##########
File path: sql/core/benchmarks/CSVBenchmark-jdk11-results.txt
##########
@@ -6,62 +6,62 @@ OpenJDK 64-Bit Server VM 11.0.7+10-post-Ubuntu-2ubuntu218.04
on Linux 4.15.0-106
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
Parsing quoted values: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-One quoted string 46568 46683
198 0.0 931358.6 1.0X
+One quoted string 53332 53484
194 0.0 1066633.5 1.0X
Review comment:
I re-ran the benchmark on the master (w/o the changes). The result is
not stable in master too:
```
[OpenJDK 64-Bit Server VM 1.8.0_252-8u252-b09-1~18.04-b09 on Linux
4.15.0-1063-aws
[Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
[Parsing quoted values: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
[------------------------------------------------------------------------------------------------------------------------
[One quoted string 49870 49912
51 0.0 997391.0 1.0X
[OpenJDK 64-Bit Server VM 1.8.0_252-8u252-b09-1~18.04-b09 on Linux
4.15.0-1063-aws
[Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
[Parsing quoted values: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
[------------------------------------------------------------------------------------------------------------------------
[One quoted string 60652 60656
3 0.0 1213047.8 1.0X
[OpenJDK 64-Bit Server VM 1.8.0_252-8u252-b09-1~18.04-b09 on Linux
4.15.0-1063-aws
[Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz
[Parsing quoted values: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
[------------------------------------------------------------------------------------------------------------------------
[One quoted string 53898 54027
135 0.0 1077952.8 1.0X
```
I compared profiler outputs, and haven't found any diffs between this PR and
master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
