dongjoon-hyun commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444075984
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala
##########
@@ -155,7 +155,7 @@ abstract class DockerJDBCIntegrationSuite extends
SharedSparkSession with Eventu
docker.startContainer(containerId)
jdbcUrl = db.getJdbcUrl(dockerIp, externalPort)
var conn: Connection = null
- eventually(timeout(2.minutes), interval(1.second)) {
+ eventually(timeout(7.minutes), interval(1.second)) {
Review comment:
@gaborgsomogyi . `7 minutes` is okay for `Oracle` suite. But, it seems
that you misunderstand my PR. You can use more higher values, but you should
not increase the timeout of the other test suites. Please see my PR. I keep
`2.minutes` for all the other test suite and only allow longer timeout for
`OracleIntegrationSuite`.
-
https://github.com/gaborgsomogyi/spark/pull/2/files#diff-bf03588f75a2d7b55214924fd611e528R99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
