[GitHub] [spark] HyukjinKwon commented on a change in pull request #28940: [SPARK-32121][SHUFFLE][TEST] Fix ExternalShuffleBlockResolverSuite failed on Windows

Mon, 29 Jun 2020 05:18:42 -0700 


HyukjinKwon commented on a change in pull request #28940:
URL: https://github.com/apache/spark/pull/28940#discussion_r446891403



##########
File path: 
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExecutorDiskUtils.java
##########
@@ -27,7 +27,7 @@
 
 public class ExecutorDiskUtils {
 
-  private static final Pattern MULTIPLE_SEPARATORS = 
Pattern.compile(File.separator + "{2,}");
+  private static final Pattern MULTIPLE_SEPARATORS = 
Pattern.compile("[/\\\\]+");

Review comment:
       I have a sort of half automated script to run the tests on Windows via 
CI AppVeyor which I used at that time to audit the tests on Windows. Let me try 
to run and see if that works:
   
   Build started: [CORE] 
`org.apache.spark.network.shuffle.ExternalShuffleBlockResolverSuite` 
[![PR-28940](https://ci.appveyor.com/api/projects/status/github/HyukjinKwon/spark?branch=66D51DFB-3C81-4172-9E99-3A56B786E809&svg=true)](https://ci.appveyor.com/project/HyukjinKwon/spark/branch/66D51DFB-3C81-4172-9E99-3A56B786E809)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to