GitHub user zsxwing opened a pull request:

    https://github.com/apache/spark/pull/5209

    [SPARK-6556][Core] Fix wrong parsing logic of executorTimeoutMs and 
checkTimeoutIntervalMs in HeartbeatReceiver

    The current reading logic of `executorTimeoutMs` is:
    ```Scala
    private val executorTimeoutMs = sc.conf.getLong("spark.network.timeout", 
        sc.conf.getLong("spark.storage.blockManagerSlaveTimeoutMs", 120)) * 1000
    ```
    So if `spark.storage.blockManagerSlaveTimeoutMs` is 10000 and 
`spark.network.timeout` is not set, executorTimeoutMs will be 10000 * 1000. But 
the correct value should have been 10000.
    
    `checkTimeoutIntervalMs` has the same issue.
    
    This PR fixes them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zsxwing/spark SPARK-6556

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/5209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5209
    
----
commit ccd514700335d40b996dafaa6c6116b4b2d38292
Author: zsxwing <[email protected]>
Date:   2015-03-26T11:56:03Z

    Fix wrong parsing logic of executorTimeoutMs and checkTimeoutIntervalMs in 
HeartbeatReceiver

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to