Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5209#discussion_r27206977
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -49,12 +49,13 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext, scheduler: TaskSchedule
// executor ID -> timestamp of when the last heartbeat from this
executor was received
private val executorLastSeen = new mutable.HashMap[String, Long]
-
- private val executorTimeoutMs = sc.conf.getLong("spark.network.timeout",
- sc.conf.getLong("spark.storage.blockManagerSlaveTimeoutMs", 120)) *
1000
-
- private val checkTimeoutIntervalMs =
sc.conf.getLong("spark.network.timeoutInterval",
- sc.conf.getLong("spark.storage.blockManagerTimeoutIntervalMs", 60)) *
1000
+
+ private val executorTimeoutMs =
sc.conf.getOption("spark.network.timeout").map(_.toLong * 1000).
--- End diff --
You might comment that `timeout` is in seconds and (obviously)
`blockManagerSlaveTimeoutMs` is milliseconds. I agree with the change though.
These properties you're fixing aren't documented right? the only ref I saw on
the mailing list clearly directed people to set values like "60000", which is
correctly in ms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
